Bug 178838 - Implement seek tolerance methods in WebAVPlayerController.
Summary: Implement seek tolerance methods in WebAVPlayerController.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-25 16:52 PDT by Jeremy Jones
Modified: 2017-11-02 11:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.12 KB, patch)
2017-10-25 16:59 PDT, Jeremy Jones 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (14.63 KB, patch)
2017-10-26 16:10 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-10-25 16:52:48 PDT 
Implement seek tolerance methods in WebAVPlayerController.
Comment 1 Jeremy Jones 2017-10-25 16:54:24 PDT 
rdar://problem/33781777
Comment 2 Jeremy Jones 2017-10-25 16:59:35 PDT 
Created attachment 324925 [details]
Patch
Comment 3 Eric Carlson 2017-10-25 17:18:50 PDT 
Comment on attachment 324925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324925&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:143
> +    void seekToTime(double, double, double) override;

Nit : some of the changes in  this patch won’t be necessary if you give the new parameters default values of 0.
Comment 4 Jeremy Jones 2017-10-26 16:10:25 PDT 
Created attachment 325074 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-10-26 23:06:42 PDT 
Comment on attachment 325074 [details]
Patch for landing

Clearing flags on attachment: 325074

Committed r224085: <https://trac.webkit.org/changeset/224085>