WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
178838
Implement seek tolerance methods in WebAVPlayerController.
https://bugs.webkit.org/show_bug.cgi?id=178838
Summary
Implement seek tolerance methods in WebAVPlayerController.
Jeremy Jones
Reported
2017-10-25 16:52:48 PDT
Implement seek tolerance methods in WebAVPlayerController.
Attachments
Patch
(15.12 KB, patch)
2017-10-25 16:59 PDT
,
Jeremy Jones
eric.carlson
: review+
Details
Formatted Diff
Diff
Patch for landing
(14.63 KB, patch)
2017-10-26 16:10 PDT
,
Jeremy Jones
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jeremy Jones
Comment 1
2017-10-25 16:54:24 PDT
rdar://problem/33781777
Jeremy Jones
Comment 2
2017-10-25 16:59:35 PDT
Created
attachment 324925
[details]
Patch
Eric Carlson
Comment 3
2017-10-25 17:18:50 PDT
Comment on
attachment 324925
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=324925&action=review
> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:143 > + void seekToTime(double, double, double) override;
Nit : some of the changes in this patch won’t be necessary if you give the new parameters default values of 0.
Jeremy Jones
Comment 4
2017-10-26 16:10:25 PDT
Created
attachment 325074
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2017-10-26 23:06:42 PDT
Comment on
attachment 325074
[details]
Patch for landing Clearing flags on attachment: 325074 Committed
r224085
: <
https://trac.webkit.org/changeset/224085
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug