DidMoveToNewDocumentAssertionScope is there to only ensure Node::didMoveToNewDocument is eventually called by implementations in derived classes. A better to way to ensure that Node::didMoveToNewDocument is always called is to simply call it directly. Since only subclasses of Element and ShadowRoot override this virtual member function and we already have a special case for ShadowRoot, we can de-vritualize for all non-Element cases.
<rdar://problem/35008876>
Created attachment 324918 [details] Cleanup
Attachment 324918 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ShadowRoot.cpp:105: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/ShadowRoot.cpp:111: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/ShadowRoot.cpp:121: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 324922 [details] Cleanup
Comment on attachment 324922 [details] Cleanup r=me
Comment on attachment 324922 [details] Cleanup Clearing flags on attachment: 324922 Committed r224053: <https://trac.webkit.org/changeset/224053>
All reviewed patches have been landed. Closing bug.