Bug 178818 – REGRESSION(r222945): "It made WasmBench crash" (Requested by saamyjoon on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Commit Bot]

https://trac.webkit.org/changeset/222945 broke the build:
"It made WasmBench crash" (Requested by saamyjoon on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 324857 [details]
ROLLOUT of r222945

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Commit Bot]

Comment on attachment 324857 [details]
ROLLOUT of r222945

Clearing flags on attachment: 324857

Committed r223965: <https://trac.webkit.org/changeset/223965>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Filip Pizlo]

(In reply to WebKit Commit Bot from comment #0)
> https://trac.webkit.org/changeset/222945 broke the build:
> "It made WasmBench crash" (Requested by saamyjoon on #webkit).
> 
> This is an automatic bug report generated by webkitbot. If this bug
> report was created because of a flaky test, please file a bug for the flaky
> test (if we don't already have one on file) and dup this bug against that bug
> so that we can track how often these flaky tests fail.

It would be super helpful if you could post the crash trace when rolling out a patch because of a crash.

[Saam Barati]

(In reply to Filip Pizlo from comment #4)
> (In reply to WebKit Commit Bot from comment #0)
> > https://trac.webkit.org/changeset/222945 broke the build:
> > "It made WasmBench crash" (Requested by saamyjoon on #webkit).
> > 
> > This is an automatic bug report generated by webkitbot. If this bug
> > report was created because of a flaky test, please file a bug for the flaky
> > test (if we don't already have one on file) and dup this bug against that bug
> > so that we can track how often these flaky tests fail.
> 
> It would be super helpful if you could post the crash trace when rolling out
> a patch because of a crash.

attached it to:
https://bugs.webkit.org/show_bug.cgi?id=177839

[Saam Barati]

*** Bug 178755 has been marked as a duplicate of this bug. ***

[Radar WebKit Bug Importer]

<rdar://problem/35568067>