Bug 178817 - PerformanceTests/TailBench9000/merge-sort.js does not actually sort any of the large arrays it allocates
Summary: PerformanceTests/TailBench9000/merge-sort.js does not actually sort any of th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-25 11:16 PDT by Robin Morisset
Modified: 2017-11-15 12:47 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2017-10-25 12:31 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Patch for landing (1.55 KB, patch)
2017-11-06 04:24 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2017-10-25 11:16:58 PDT 
More precisely, it allocates several arrays, some small, some large, some sorted, some sorted in reverse order, some random... then it only test the sort on the first of these, which is small and already sorted.
I have a trivial patch for it.
Comment 1 Robin Morisset 2017-10-25 12:31:32 PDT 
Created attachment 324863 [details]
Patch
Comment 2 Saam Barati 2017-10-25 12:33:31 PDT 
Comment on attachment 324863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324863&action=review

> PerformanceTests/TailBench9000/merge-sort.js:154
> +noInline(TEST_mergeSort);

Why do this? This will make the test not-runnable in browser.
Comment 3 Robin Morisset 2017-11-06 04:24:41 PST 
Created attachment 326112 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-11-06 04:56:55 PST 
Comment on attachment 326112 [details]
Patch for landing

Clearing flags on attachment: 326112

Committed r224485: <https://trac.webkit.org/changeset/224485>
Comment 5 WebKit Commit Bot 2017-11-06 04:56:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:47:44 PST 
<rdar://problem/35568073>