Bug 178815 - Add a third benchmark to TailBench
Summary: Add a third benchmark to TailBench
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-25 10:55 PDT by Robin Morisset
Modified: 2017-11-15 12:58 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.88 KB, patch)
2017-10-25 11:11 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff
Patch for landing (5.82 KB, patch)
2017-11-06 04:27 PST, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2017-10-25 10:55:05 PDT
JavascriptCore currently has two tail-call focused benchmarks: TailBench9000/merge-sort.js and TailBench9000/n-body.js.
I have found it useful to have a third data point when running some performance experiment (such as in the comments of https://bugs.webkit.org/show_bug.cgi?id=178389).
Comment 1 Robin Morisset 2017-10-25 11:11:03 PDT
Created attachment 324852 [details]
Patch
Comment 2 Saam Barati 2017-10-25 12:34:59 PDT
Comment on attachment 324852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324852&action=review

> Tools/ChangeLog:8
> +        Add a new benchmark to TailBench: a brainfuck interpreter written in a weird kinda functional style

perhaps better not to use "fuck" in a changelog entry

> PerformanceTests/ChangeLog:8
> +        Add a new benchmark to TailBench: a brainfuck interpreter written in a weird kinda functional style

perhaps better not to use "fuck" in a changelog entry
Comment 3 Robin Morisset 2017-11-06 04:27:17 PST
Created attachment 326113 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-11-06 04:58:46 PST
Comment on attachment 326113 [details]
Patch for landing

Clearing flags on attachment: 326113

Committed r224486: <https://trac.webkit.org/changeset/224486>
Comment 5 WebKit Commit Bot 2017-11-06 04:58:47 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:58:59 PST
<rdar://problem/35568536>