Bug 178814 - Web Inspector: Canvas Tab: selected canvas card loses selection outline style while recording
Summary: Web Inspector: Canvas Tab: selected canvas card loses selection outline style...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: WebInspectorCanvasRecording WebInspectorCanvasTab
  Show dependency treegraph
 
Reported: 2017-10-25 10:49 PDT by Brian Burg
Modified: 2017-12-04 17:40 PST (History)
5 users (show)

See Also:


Attachments
[Image] Screenshot of issue (315.56 KB, image/png)
2017-10-25 13:02 PDT, Devin Rousso
no flags Details
Patch (3.46 KB, patch)
2017-10-25 13:12 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (315.75 KB, image/png)
2017-10-25 13:13 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-10-25 10:49:50 PDT
This is awkward because I can't tell what the selection is, except by looking at the jump bar. If needed I suppose the red part could stay red, but the rest should be blue.
Comment 1 Radar WebKit Bug Importer 2017-10-25 10:50:09 PDT
<rdar://problem/35177317>
Comment 2 Devin Rousso 2017-10-25 13:02:35 PDT
Created attachment 324872 [details]
[Image] Screenshot of issue

This was done intentionally.

WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css:40
    .content-view.canvas-overview .content-view.canvas.selected:not(.is-recording) {
        border-color: var(--selected-background-color);
    }

It looks quite awful to have the red and blue right next to each other.  I agree that we still need some visual indicator, so maybe we should have the header stay red when recording and the rest of the borders be blue.
Comment 3 Devin Rousso 2017-10-25 13:12:41 PDT
Created attachment 324875 [details]
Patch
Comment 4 Devin Rousso 2017-10-25 13:13:20 PDT
Created attachment 324876 [details]
[Image] After Patch is applied
Comment 5 Brian Burg 2017-10-25 13:19:12 PDT
Comment on attachment 324875 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-10-25 14:12:03 PDT
Comment on attachment 324875 [details]
Patch

Clearing flags on attachment: 324875

Committed r223979: <https://trac.webkit.org/changeset/223979>
Comment 7 WebKit Commit Bot 2017-10-25 14:12:05 PDT
All reviewed patches have been landed.  Closing bug.