Bug 178806 – Web Inspector: Canvas Tab: canvas path components from old page stick around when page is reloaded

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Created attachment 324841 [details]
Screenshot

STR:

1. Load acko.net
2. Open Inspector, Canvases Tab
3. Reload the page several times
=> Now I have multiple Canvas 2, Canvas 3 path components

[Radar WebKit Bug Importer]

<rdar://problem/35176360>

[Devin Rousso]

Created attachment 324912 [details]
Patch

[Blaze Burg]

Comment on attachment 324912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324912&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +

You never really explained why the code was wrong or what the fix does differently.

> Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:185
> +        for (let recording of canvas.recordingCollection.items) {

I would comment here that we are converting the gone canvas' recordings to be imported recordings.

[Devin Rousso]

Created attachment 325093 [details]
Patch

Added comments.  No change in logic.

[WebKit Commit Bot]

Comment on attachment 325093 [details]
Patch

Clearing flags on attachment: 325093

Committed r224081: <https://trac.webkit.org/changeset/224081>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.