LayoutController.
<rdar://problem/35166542>
Created attachment 324790 [details] Patch
Created attachment 324792 [details] Patch
Created attachment 324817 [details] Patch
Created attachment 324832 [details] Patch
Created attachment 324850 [details] Patch
Created attachment 324864 [details] Patch
Created attachment 324873 [details] Patch
Created attachment 324879 [details] Patch
Created attachment 324890 [details] Patch
Created attachment 324896 [details] Patch
Created attachment 324898 [details] Patch
Comment on attachment 324890 [details] Patch Attachment 324890 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4988591 New failing tests: compositing/iframes/page-cache-layer-tree.html
Created attachment 324903 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324896 [details] Patch Attachment 324896 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4988989 New failing tests: compositing/iframes/page-cache-layer-tree.html
Created attachment 324907 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324898 [details] Patch Attachment 324898 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4989163 New failing tests: compositing/iframes/page-cache-layer-tree.html
Created attachment 324910 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 324914 [details] Patch
Comment on attachment 324896 [details] Patch Attachment 324896 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4989327 New failing tests: compositing/iframes/page-cache-layer-tree.html
Created attachment 324915 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324890 [details] Patch Attachment 324890 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4989436 New failing tests: compositing/iframes/page-cache-layer-tree.html
Created attachment 324916 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324898 [details] Patch Attachment 324898 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4989705 New failing tests: compositing/iframes/page-cache-layer-tree.html
Created attachment 324924 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324914&action=review > Source/WebCore/page/FrameView.h:917 > + LayoutController m_layoutController; Oh, a layout controller is a persistent object. I guess it's okay to call it a controller in that case (as opposed to LayoutContext).
Created attachment 324939 [details] Patch
Comment on attachment 324898 [details] Patch Attachment 324898 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4991845 New failing tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm compositing/iframes/page-cache-layer-tree.html http/tests/appcache/decide-navigation-policy-after-delay.html
Created attachment 324941 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 324943 [details] Patch
Created attachment 324954 [details] Patch
Created attachment 325010 [details] Patch
Created attachment 325060 [details] Patch
Comment on attachment 325060 [details] Patch Attachment 325060 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5003891 New failing tests: fast/repaint/fixed-right-bottom-in-page-scale.html fullscreen/full-screen-restrictions.html
Created attachment 325078 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 325092 [details] Patch
Comment on attachment 325092 [details] Patch Attachment 325092 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5006393 New failing tests: imported/blink/fast/frames/frameset-dynamic-resize.html fast/parser/fragment-with-frameset-crash.html http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html inspector/dom/push-node-by-path-to-frontend.html fast/frames/frameset-frameborder-inheritance.html accessibility/frame-disconnect-textmarker-cache-crash.html fast/frames/frameset-frameborder-boolean-values.html fast/frames/frameset-frameborder-overrides-border.html fast/frames/negative-remaining-length-crash.html accessibility/mac/document-attributes.html
Created attachment 325100 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325092 [details] Patch Attachment 325092 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5006420 New failing tests: imported/blink/fast/frames/frameset-dynamic-resize.html http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html fast/parser/fragment-with-frameset-crash.html accessibility/frame-disconnect-textmarker-cache-crash.html inspector/dom/push-node-by-path-to-frontend.html fast/frames/frameset-frameborder-inheritance.html fast/frames/frameset-frameborder-boolean-values.html fast/frames/frameset-frameborder-overrides-border.html fast/frames/negative-remaining-length-crash.html accessibility/mac/document-attributes.html
Created attachment 325102 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325092 [details] Patch Attachment 325092 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5006717 New failing tests: imported/blink/fast/frames/frameset-dynamic-resize.html fast/parser/fragment-with-frameset-crash.html
Created attachment 325108 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 325115 [details] Patch
Comment on attachment 325092 [details] Patch Attachment 325092 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5007354 New failing tests: imported/blink/fast/frames/frameset-dynamic-resize.html fast/parser/fragment-with-frameset-crash.html fast/frames/frame-set-same-location.html fast/frames/frame-set-scaling-rotate.html css3/viewport-percentage-lengths/vh-auto-size.html accessibility/mac/document-attributes.html
Created attachment 325122 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 325125 [details] Patch
Attachment 325125 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:677: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325196 [details] Patch
Attachment 325196 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:677: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325196&action=review > Source/WebCore/ChangeLog:9 > + Move layout code out from FrameView to LayoutContext. A few more words here.
Created attachment 325208 [details] Patch
Attachment 325208 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:677: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325241 [details] Patch
Attachment 325241 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:677: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325241 [details] Patch Clearing flags on attachment: 325241 Committed r224150: <https://trac.webkit.org/changeset/224150>
All reviewed patches have been landed. Closing bug.