Bug 178764 - Make SharedStringHashTable less error prone
Summary: Make SharedStringHashTable less error prone
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-24 16:58 PDT by Chris Dumez
Modified: 2017-11-15 12:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.39 KB, patch)
2017-10-24 18:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (21.62 KB, patch)
2017-10-25 09:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (21.57 KB, patch)
2017-10-25 10:04 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-24 16:58:21 PDT 
Make SharedStringHashTable less error prone by moving its modifying operations into a subclass.
Comment 1 Chris Dumez 2017-10-24 18:57:15 PDT 
Created attachment 324774 [details]
Patch
Comment 2 youenn fablet 2017-10-25 09:32:46 PDT 
Comment on attachment 324774 [details]
Patch

LGTM.
Usually classes are split in their own files. Maybe this should be done here as well.
That way, some files would only include the ReadOnly version.
Comment 3 Chris Dumez 2017-10-25 09:49:08 PDT 
Created attachment 324834 [details]
Patch
Comment 4 Chris Dumez 2017-10-25 10:04:36 PDT 
Created attachment 324839 [details]
Patch
Comment 5 Chris Dumez 2017-10-25 10:19:47 PDT 
Comment on attachment 324839 [details]
Patch

Clearing flags on attachment: 324839

Committed r223958: <https://trac.webkit.org/changeset/223958>
Comment 6 Chris Dumez 2017-10-25 10:19:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 12:46:35 PST 
<rdar://problem/35568098>