Bug 178761 - ServiceWorkerClientFetch should return an error that is not null in case of failure
Summary: ServiceWorkerClientFetch should return an error that is not null in case of f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-24 16:26 PDT by youenn fablet
Modified: 2017-11-15 12:50 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.71 KB, patch)
2017-10-24 16:35 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.85 KB, patch)
2017-10-24 16:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-10-24 16:26:21 PDT 
ServiceWorkerClientFetch should return an error that is not null in case of failure
Comment 1 youenn fablet 2017-10-24 16:35:10 PDT 
Created attachment 324750 [details]
Patch
Comment 2 youenn fablet 2017-10-24 16:47:52 PDT 
Created attachment 324756 [details]
Patch
Comment 3 Geoffrey Garen 2017-10-24 16:49:12 PDT 
Comment on attachment 324756 [details]
Patch

r=me
Comment 4 Geoffrey Garen 2017-10-24 16:49:28 PDT 
Can we add a test for this now that we have hello world?
Comment 5 youenn fablet 2017-10-24 17:12:43 PDT 
(In reply to Geoffrey Garen from comment #4)
> Can we add a test for this now that we have hello world?

Thanks for the review.
The change is covered by basic-registration.html.
The change to make use of ResourceError::Type::General makes basic-registration.html to fail. By fixing WorkerScriptLoader to not use service worker, we are back to the usual way.
Comment 6 WebKit Commit Bot 2017-10-24 17:47:30 PDT 
Comment on attachment 324756 [details]
Patch

Clearing flags on attachment: 324756

Committed r223944: <https://trac.webkit.org/changeset/223944>
Comment 7 WebKit Commit Bot 2017-10-24 17:47:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-11-15 12:50:04 PST 
<rdar://problem/35568238>