Bug 178758 - [CG] Remove the JPEG2000 from WebKit image format whitelist
Summary: [CG] Remove the JPEG2000 from WebKit image format whitelist
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-24 15:57 PDT by Said Abou-Hallawa
Modified: 2019-01-07 10:32 PST (History)
10 users (show)

See Also:


Attachments
Patch (7.01 KB, patch)
2017-10-24 18:46 PDT, Said Abou-Hallawa
darin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2017-10-24 15:57:39 PDT
From http://caniuse.com/#search=jpeg2000, Safari is the only browser which supports JPEG2000. Because no other browser is adopting JPEG2000, then there's no real reason for WebKit to keep exposing it.
Comment 1 Radar WebKit Bug Importer 2017-10-24 15:58:29 PDT
<rdar://problem/35161822>
Comment 2 Said Abou-Hallawa 2017-10-24 18:46:12 PDT
Created attachment 324771 [details]
Patch
Comment 3 Sam Weinig 2017-10-25 08:03:44 PDT
This seems like this should be runtime configurable for clients of the WebKit API that want to continue supporting JPEG2000.
Comment 4 mitz 2017-10-25 10:04:56 PDT
(In reply to Sam Weinig from comment #3)
> This seems like this should be runtime configurable for clients of the
> WebKit API that want to continue supporting JPEG2000.

And not drop support for clients that linked against a version of WebKit hat had support.
Comment 5 Said Abou-Hallawa 2017-10-25 12:02:46 PDT
(In reply to mitz from comment #4)
> (In reply to Sam Weinig from comment #3)
> > This seems like this should be runtime configurable for clients of the
> > WebKit API that want to continue supporting JPEG2000.
> 
> And not drop support for clients that linked against a version of WebKit hat
> had support.

I filed https://bugs.webkit.org/show_bug.cgi?id=178821.
Comment 6 Michael Catanzaro 2018-04-24 12:50:40 PDT
This is causing web compat issues for other ports, see bug #180995
Comment 7 Michael Catanzaro 2018-08-06 12:56:30 PDT
(In reply to Said Abou-Hallawa from comment #0)
> From http://caniuse.com/#search=jpeg2000, Safari is the only browser which
> supports JPEG2000. Because no other browser is adopting JPEG2000, then
> there's no real reason for WebKit to keep exposing it.

Also bug #186272

I think we will have to add JPEG2000 support to GTK and WPE (not really desired) unless Safari drops it.
Comment 8 Said Abou-Hallawa 2018-10-26 11:42:05 PDT
We saw washingtonpost.com uses JP2000 images recently. So I think it is okay to keep the support for now and not to fix this bug.
Comment 9 Michael Catanzaro 2018-10-26 12:27:58 PDT
Well a *lot* of websites are (or were recently) sending JP2000 images (dell.com, kmart.com, I think perhaps amd.com (though this one is sending weird PNGs too so not certain). It's a significant web compat issue for us right now.

We need to either:

 (a) Remove support from Safari, temporarily breaking these websites in Safari
 (b) Add support to WPE/GTK

We had been expecting you to do (a), so if that's no longer the plan, we'll need to work on (b).
Comment 10 Michael Catanzaro 2018-12-18 13:13:44 PST
Adrian discovered every instance of JPEG 2000 images I'm aware of are on websites using Akamai Image Manager. This affects both images with the .jpg extension and also .png; the images seem to be reencoded without changing the filename. It only sends JPEG 2000 images for websites that include Safari without Chromium in the user agent.

We currently intend to implement support for JPEG 2000, but if Apple still wants to remove it, probably working with Akamai Image Manager would be the first step.

Sample JPEG 2000 images:

https://www.angieslist.com/sites/all/themes/altheme/images/home-hero-overlay.png

https://www.amd.com/system/files/styles/992px/private/65942-ryzen-threadripper-pib-ces-front-facing-1260x709_4.png

https://i.dell.com/sites/csimages/Banner_Imagery/all/25957-laptop-inspiron-14-5481-desktop-3670mt-monitor-d3218hn-2800x944.jpg

https://www.akamai.com/us/en/multimedia/images/article/akamai-image-manager-overview-image.jpg?imwidth=1366
Comment 11 Michael Catanzaro 2018-12-18 13:16:33 PST
Repurposed bug #186272 to implement JPEG 2000 for non-Apple ports. (If Safari will be removing JPEG 2000 support, please let us know so we don't have to do this!)