Bug 178753 - Web Inspector: Console Drawer resizing doesn't match cursor position
Summary: Web Inspector: Console Drawer resizing doesn't match cursor position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-24 15:04 PDT by Joseph Pecoraro
Modified: 2017-10-24 15:12 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.56 KB, patch)
2017-10-24 15:06 PDT, Joseph Pecoraro 		bburg: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (2.56 KB, patch)
2017-10-24 15:08 PDT, Joseph Pecoraro 		bburg: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-10-24 15:04:23 PDT 
Console Drawer resizing doesn't match cursor position.

Resizing the console drawer doesn't actually match the cursor. Even though we set the height to a fixed value (like 600px) the content area's height: 100% proportions the drawer's height, so it might only end up like 345px.
Comment 1 Radar WebKit Bug Importer 2017-10-24 15:04:51 PDT 
<rdar://problem/35160484>
Comment 2 Joseph Pecoraro 2017-10-24 15:06:29 PDT 
Created attachment 324731 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2017-10-24 15:08:06 PDT 
Comment on attachment 324731 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=324731&action=review

> Source/WebInspectorUI/ChangeLog:16
> +        already was but now it does not affect the size of the fixed with sibling.

"fixed with" => "fixed height" oop.
Comment 4 BJ Burg 2017-10-24 15:08:50 PDT 
Comment on attachment 324731 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=324731&action=review

r=me

> Source/WebInspectorUI/ChangeLog:16
> +        already was but now it does not affect the size of the fixed with sibling.

Nit: was, but
Nit: fixed-width
Comment 5 Joseph Pecoraro 2017-10-24 15:08:58 PDT 
Created attachment 324733 [details]
[PATCH] Proposed Fix
Comment 6 BJ Burg 2017-10-24 15:09:20 PDT 
(In reply to Brian Burg from comment #4)
> Comment on attachment 324731 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324731&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/ChangeLog:16
> > +        already was but now it does not affect the size of the fixed with sibling.
> 
> Nit: was, but
> Nit: fixed-width

But really, fixed-height =)
Comment 7 Joseph Pecoraro 2017-10-24 15:12:39 PDT 
<https://trac.webkit.org/r223931>