Bug 178740 - Need to pass non-nil argument to SimulateCrash() in bmalloc::logVMFailure()
Summary: Need to pass non-nil argument to SimulateCrash() in bmalloc::logVMFailure()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 155409
Blocks:
  Show dependency treegraph
 
Reported: 2017-10-24 11:34 PDT by David Kilzer (:ddkilzer)
Modified: 2017-10-24 15:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch v1 (3.86 KB, patch)
2017-10-24 13:02 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (3.75 KB, patch)
2017-10-24 13:07 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v3 (4.22 KB, patch)
2017-10-24 13:34 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-10-24 11:34:07 PDT
In order to get logs, we need to pass a non-nil argument in bmalloc::logVMFailure().
Comment 1 Radar WebKit Bug Importer 2017-10-24 11:34:32 PDT
<rdar://problem/35154943>
Comment 2 David Kilzer (:ddkilzer) 2017-10-24 13:02:08 PDT
Created attachment 324706 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2017-10-24 13:07:40 PDT
Created attachment 324709 [details]
Patch v2
Comment 4 David Kilzer (:ddkilzer) 2017-10-24 13:34:21 PDT
Created attachment 324714 [details]
Patch v3
Comment 5 WebKit Commit Bot 2017-10-24 15:30:19 PDT
Comment on attachment 324714 [details]
Patch v3

Clearing flags on attachment: 324714

Committed r223936: <https://trac.webkit.org/changeset/223936>
Comment 6 WebKit Commit Bot 2017-10-24 15:30:20 PDT
All reviewed patches have been landed.  Closing bug.