Bug 178735 - Add support for unregistering a service worker
Summary: Add support for unregistering a service worker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2017-10-24 11:00 PDT by Chris Dumez
Modified: 2017-11-15 12:49 PST (History)
4 users (show)

See Also:

Attachments
WIP Patch (24.32 KB, patch)
2017-10-24 12:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.42 KB, patch)
2017-10-24 13:07 PDT, Chris Dumez 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-24 11:00:34 PDT 
Add support for unregistering a service worker:
- https://w3c.github.io/ServiceWorker/#navigator-service-worker-unregister
Comment 1 Chris Dumez 2017-10-24 12:23:37 PDT 
Created attachment 324701 [details]
WIP Patch
Comment 2 Chris Dumez 2017-10-24 13:07:06 PDT 
Created attachment 324708 [details]
Patch
Comment 3 Brady Eidson 2017-10-25 11:23:57 PDT 
Comment on attachment 324708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324708&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:181
> +    // If the origin of jobâs scope url is not jobâs client's origin, then:

Get rid of some unicode stuff (check-webkit-style used to catch these things)
Comment 4 Chris Dumez 2017-10-25 11:29:00 PDT 
Committed r223964: <https://trac.webkit.org/changeset/223964>
Comment 5 Radar WebKit Bug Importer 2017-11-15 12:49:12 PST 
<rdar://problem/35568210>