Bug 178716 - RenderThemeCocoa::mediaControlsFormattedStringForDuration may cause a crash due to unhandled Obj-C exception
Summary: RenderThemeCocoa::mediaControlsFormattedStringForDuration may cause a crash d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-24 00:34 PDT by Antoine Quint
Modified: 2017-10-24 10:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2017-10-24 00:35 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (2.11 KB, patch)
2017-10-24 09:58 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-10-24 00:34:04 PDT
We need to wrap calls to NSDateComponentsFormatter in a BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS block.
Comment 1 Antoine Quint 2017-10-24 00:34:17 PDT
<rdar://problem/35112900>
Comment 2 Antoine Quint 2017-10-24 00:35:31 PDT
Created attachment 324657 [details]
Patch
Comment 3 Antoine Quint 2017-10-24 09:58:16 PDT
Created attachment 324681 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-10-24 10:32:14 PDT
Comment on attachment 324681 [details]
Patch for landing

Clearing flags on attachment: 324681

Committed r223896: <https://trac.webkit.org/changeset/223896>
Comment 5 WebKit Commit Bot 2017-10-24 10:32:16 PDT
All reviewed patches have been landed.  Closing bug.