Let's fix this: [2219/3619] Building CXX object Source...unified-sources/UnifiedSource260.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource260.cpp:1:0: ../../Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:664:7: warning: ‘WebCore::ClearObjectStore’ has a field ‘WebCore::ClearObjectStore::<anonymous>’ whose type uses the anonymous namespace [-Wsubobject-linkage] class ClearObjectStore final : public ExecutableWithDatabase { ^~~~~~~~~~~~~~~~ ../../Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:664:7: warning: ‘WebCore::ClearObjectStore’ has a base ‘WebCore::{anonymous}::ExecutableWithDatabase’ whose type uses the anonymous namespace [-Wsubobject-linkage]
Created attachment 324635 [details] Patch
Comment on attachment 324635 [details] Patch Interesting. Should we put this in the same anonymous namespace as the stuff at the top of the file? If this is enough though, r=me
There's only one anonymous namespace per translation unit (normally that's one file, but for us now that's a unified source bundle). So it doesn't matter where it goes. Up to you; I figured the class is in its current location for a reason.
Comment on attachment 324635 [details] Patch Clearing flags on attachment: 324635 Committed r223885: <https://trac.webkit.org/changeset/223885>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35568516>