Bug 178698 - -Wsubobject-linkage warning in InspectorIndexedDBAgent.cpp
Summary: -Wsubobject-linkage warning in InspectorIndexedDBAgent.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Keywords: InRadar
Depends on:
Reported: 2017-10-23 19:27 PDT by Michael Catanzaro
Modified: 2017-11-15 13:01 PST (History)
5 users (show)

See Also:

Patch (1.68 KB, patch)
2017-10-23 21:13 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-10-23 19:27:34 PDT
Let's fix this:

[2219/3619] Building CXX object Source...unified-sources/UnifiedSource260.cpp.o
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource260.cpp:1:0:
../../Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:664:7: warning: ‘WebCore::ClearObjectStore’ has a field ‘WebCore::ClearObjectStore::<anonymous>’ whose type uses the anonymous namespace [-Wsubobject-linkage]
 class ClearObjectStore final : public ExecutableWithDatabase {
../../Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:664:7: warning: ‘WebCore::ClearObjectStore’ has a base ‘WebCore::{anonymous}::ExecutableWithDatabase’ whose type uses the anonymous namespace [-Wsubobject-linkage]
Comment 1 Michael Catanzaro 2017-10-23 21:13:58 PDT
Created attachment 324635 [details]
Comment 2 Joseph Pecoraro 2017-10-23 21:16:09 PDT
Comment on attachment 324635 [details]

Interesting. Should we put this in the same anonymous namespace as the stuff at the top of the file? If this is enough though, r=me
Comment 3 Michael Catanzaro 2017-10-23 21:33:05 PDT
There's only one anonymous namespace per translation unit (normally that's one file, but for us now that's a unified source bundle). So it doesn't matter where it goes. Up to you; I figured the class is in its current location for a reason.
Comment 4 WebKit Commit Bot 2017-10-24 01:38:32 PDT
Comment on attachment 324635 [details]

Clearing flags on attachment: 324635

Committed r223885: <https://trac.webkit.org/changeset/223885>
Comment 5 WebKit Commit Bot 2017-10-24 01:38:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 13:01:46 PST