Bug 178680 - Stop using _UIApplicationUsesLegacyUI()
Summary: Stop using _UIApplicationUsesLegacyUI()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-23 14:06 PDT by Tim Horton
Modified: 2017-10-23 14:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.94 KB, patch)
2017-10-23 14:09 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (3.96 KB, patch)
2017-10-23 14:22 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-10-23 14:06:57 PDT 
Stop using _UIApplicationUsesLegacyUI()
Comment 1 Tim Horton 2017-10-23 14:09:08 PDT 
Created attachment 324584 [details]
Patch
Comment 2 mitz 2017-10-23 14:18:24 PDT 
Comment on attachment 324584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324584&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:268
> +    CGFloat initialFontSize = cell.textLabel.font.pointSize;
> +    UIFont *font = cell.textLabel.font;

Flip the order and you can just initialize initialFontSize to font.pointSize.

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:393
> +    BOOL needsNavigationController = title.length;

!!title.length for targets where BOOL is a char.
Comment 3 Tim Horton 2017-10-23 14:20:35 PDT 
<rdar://problem/35131949>
Comment 4 Tim Horton 2017-10-23 14:22:40 PDT 
Created attachment 324587 [details]
Patch
Comment 5 WebKit Commit Bot 2017-10-23 14:58:45 PDT 
Comment on attachment 324587 [details]
Patch

Clearing flags on attachment: 324587

Committed r223857: <https://trac.webkit.org/changeset/223857>
Comment 6 WebKit Commit Bot 2017-10-23 14:58:47 PDT 
All reviewed patches have been landed.  Closing bug.