Bug 178673 – Enable ServiceWorker to fetch resources

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Currently, it posts a task to the main thread that does nothing.

[youenn fablet]

Created attachment 324601 [details]
Patch

[youenn fablet]

Created attachment 324605 [details]
Patch

[youenn fablet]

Created attachment 324608 [details]
Patch

[Build Bot]

Comment on attachment 324608 [details]
Patch

Attachment 324608 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4963918

New failing tests:
http/tests/workers/service/service-worker-fetch.https.html

[Build Bot]

Created attachment 324619 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[youenn fablet]

Created attachment 324627 [details]
Patch

[youenn fablet]

Created attachment 324678 [details]
Patch

[Build Bot]

Attachment 324678 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Comment on attachment 324678 [details]
Patch

Will fix GTK?WPE, Putting it r? for early feedback request

[Alex Christensen]

Comment on attachment 324678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324678&action=review

> Source/WebCore/loader/FrameLoaderClient.h:121
> +    virtual uint64_t pageID() const { return 0; }
> +    virtual uint64_t frameID() const { return 0; }

I don't think we should have a default implementation of these.  This class is virtual anyways.

[youenn fablet]

Created attachment 324689 [details]
Patch

[youenn fablet]

Created attachment 324704 [details]
Patch

[Build Bot]

Attachment 324704 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 324752 [details]
Rebasing

[Build Bot]

Attachment 324752 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 324754 [details]
Fixing didFinish/didFail

[Build Bot]

Attachment 324754 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

This patch is moving frameID/pageID to FrameLoaderClient.
A request is associated to a client which can be a document or worker scope typically.
We might want to move from frameID/pageID to something like a clientID in the future.

This patch also introduces ServiceWorkerProcessProxy in an attempt towards an independent ServiceWorkerProcess.

[Brady Eidson]

Comment on attachment 324754 [details]
Fixing didFinish/didFail

View in context: https://bugs.webkit.org/attachment.cgi?id=324754&action=review

Make Windows build.

> Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.cpp:75
> +    }
> +    PAL::SessionID sessionID() const final { return m_sessionID; }

Empty line between these

> Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:207
> +    ASSERT_NOT_REACHED();

RELEASE_*

> Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:219
> +    ASSERT_NOT_REACHED();
> +    return 0;
> +}
> +
> +PAL::SessionID WebFrameLoaderClient::sessionID() const
> +{
> +    ASSERT_NOT_REACHED();

Ditto

[youenn fablet]

Created attachment 324869 [details]
Patch for landing

[Build Bot]

Attachment 324869 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 324869 [details]
Patch for landing

Clearing flags on attachment: 324869

Committed r223981: <https://trac.webkit.org/changeset/223981>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568839>