WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
178651
Call FrameView::scheduleSelectionUpdate when selection needs repainting after layout instead of setting the RenderView dirty.
https://bugs.webkit.org/show_bug.cgi?id=178651
Summary
Call FrameView::scheduleSelectionUpdate when selection needs repainting after...
zalan
Reported
2017-10-22 19:43:59 PDT
In
https://trac.webkit.org/r167845
(
bug 132172
), the renderView->setNeedsLayout() call was introduced to trigger selection update. However this is problematic in a couple of different ways. 1. marking the root renderer dirty does not trigger layout (this is very specific to the root, other renderers do trigger layout) -so this works as long as someone else schedules a layout. 2. when a subtree layout is already scheduled and we mark the root renderer dirty, the root gets stuck with the dirty flag (since the entry point for the subsequent layout is a descendant of the root and not the root itself). -this got revealed with
bug 178621
.
Attachments
Patch
(3.70 KB, patch)
2017-10-22 20:16 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-10-22 19:51:05 PDT
<
rdar://problem/35117448
>
zalan
Comment 2
2017-10-22 20:16:43 PDT
Created
attachment 324539
[details]
Patch
WebKit Commit Bot
Comment 3
2017-10-23 08:57:55 PDT
Comment on
attachment 324539
[details]
Patch Clearing flags on attachment: 324539 Committed
r223835
: <
https://trac.webkit.org/changeset/223835
>
WebKit Commit Bot
Comment 4
2017-10-23 08:57:56 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 5
2017-10-23 10:13:10 PDT
Comment on
attachment 324539
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=324539&action=review
> Source/WebCore/page/FrameView.cpp:3192 > + // However we can't tell at this point if the tree is stable yet, so let's just schedule a root only layout for now.
"root only" sounds weird.
Simon Fraser (smfr)
Comment 6
2017-10-23 10:14:16 PDT
You didn't undo the TestExpectation changes in
https://bugs.webkit.org/attachment.cgi?id=324541
?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug