Bug 178650 - REGRESSION(r219675): Web Inspector: CommandLineAPI getEventListeners does not work
Summary: REGRESSION(r219675): Web Inspector: CommandLineAPI getEventListeners does not...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-22 15:25 PDT by Joseph Pecoraro
Modified: 2017-10-22 18:35 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.55 KB, patch)
2017-10-22 15:29 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-10-22 15:25:44 PDT 
REGRESSION(r219675): Web Inspector: CommandLineAPI getEventListeners does not work

After refactoring the code had:

    if (m_domAgent)
        return;

Instead of:

    if (!m_domAgent)
        return;

---

Add a test, and modernize the results to match other browsers by including more information about the listeners.
Comment 1 Radar WebKit Bug Importer 2017-10-22 15:28:12 PDT 
<rdar://problem/35116347>
Comment 2 Joseph Pecoraro 2017-10-22 15:29:03 PDT 
Created attachment 324534 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2017-10-22 15:29:57 PDT 
Found this by looking at static analyzer warnings in inspector code.
Comment 4 WebKit Commit Bot 2017-10-22 17:43:42 PDT 
Comment on attachment 324534 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 324534

Committed r223826: <https://trac.webkit.org/changeset/223826>
Comment 5 WebKit Commit Bot 2017-10-22 17:43:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2017-10-22 18:35:27 PDT 
Comment on attachment 324534 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=324534&action=review

> LayoutTests/inspector/console/command-line-api-getEventListeners.html:26
> +    InspectorTest.debug();

Oops, I'll remove this at some point. Its not harmful to land with this in it just generates unnecessary stderr.