Bug 178648 - [JSC] Drop ArityCheckData
Summary: [JSC] Drop ArityCheckData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-22 14:11 PDT by Yusuke Suzuki
Modified: 2017-11-15 12:57 PST (History)
10 users (show)

See Also:

Attachments
Patch (6.63 KB, patch)
2017-10-22 14:14 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-10-22 14:11:30 PDT 
[JSC] Drop ArityCheckData
Comment 1 Yusuke Suzuki 2017-10-22 14:14:36 PDT 
Created attachment 324532 [details]
Patch
Comment 2 Mark Lam 2017-10-24 09:28:02 PDT 
Comment on attachment 324532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582
> +    move r1, t1

nit: would be nice to add a comment # r1 contains slotsToAdd.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517
> +    move r1, t1

ditto for adding a comment about r1.
Comment 3 Yusuke Suzuki 2017-10-24 09:35:55 PDT 
Comment on attachment 324532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review

Thank you for your review

>> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582
>> +    move r1, t1
> 
> nit: would be nice to add a comment # r1 contains slotsToAdd.

Sounds nice, fixed.

>> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517
>> +    move r1, t1
> 
> ditto for adding a comment about r1.

Ditto.
Comment 4 Yusuke Suzuki 2017-10-24 09:36:46 PDT 
Committed r223891: <https://trac.webkit.org/changeset/223891>
Comment 5 Radar WebKit Bug Importer 2017-11-15 12:57:38 PST 
<rdar://problem/35568480>