[JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling
Created attachment 324530 [details] Patch
Comment on attachment 324530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review > Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976 > + linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset); Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth making a wrapper function that just passes these values so all you need to pass in is iter?
Comment on attachment 324530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review >> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976 >> + linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset); > > Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth making a wrapper function that just passes these values so all you need to pass in is iter? Sounds nice! I've created `linkAllSlowCases(iter)`. I think it is very clean comparing with `linkSlowCase(iter)` function.
Committed r223824: <https://trac.webkit.org/changeset/223824>
<rdar://problem/35568443>