Bug 178647 - [JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling
Summary: [JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-22 10:49 PDT by Yusuke Suzuki
Modified: 2017-11-15 12:56 PST (History)
7 users (show)

See Also:


Attachments
Patch (49.07 KB, patch)
2017-10-22 10:55 PDT, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-10-22 10:49:38 PDT
[JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling
Comment 1 Yusuke Suzuki 2017-10-22 10:55:10 PDT
Created attachment 324530 [details]
Patch
Comment 2 Saam Barati 2017-10-22 11:02:47 PDT
Comment on attachment 324530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review

> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976
> +    linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset);

Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth making a wrapper function that just passes these values so all you need to pass in is iter?
Comment 3 Yusuke Suzuki 2017-10-22 11:07:36 PDT
Comment on attachment 324530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review

>> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976
>> +    linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset);
> 
> Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth making a wrapper function that just passes these values so all you need to pass in is iter?

Sounds nice! I've created `linkAllSlowCases(iter)`. I think it is very clean comparing with `linkSlowCase(iter)` function.
Comment 4 Yusuke Suzuki 2017-10-22 11:28:33 PDT
Committed r223824: <https://trac.webkit.org/changeset/223824>
Comment 5 Radar WebKit Bug Importer 2017-11-15 12:56:52 PST
<rdar://problem/35568443>