Bug 178646 - [JSC] Clean up baseline slow path
Summary: [JSC] Clean up baseline slow path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-22 09:04 PDT by Yusuke Suzuki
Modified: 2017-11-15 12:56 PST (History)
7 users (show)

See Also:

Attachments
Patch (27.82 KB, patch)
2017-10-22 09:06 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-10-22 09:04:26 PDT 
[JSC] Clean up baseline slow path
Comment 1 Yusuke Suzuki 2017-10-22 09:06:03 PDT 
Created attachment 324528 [details]
Patch
Comment 2 Build Bot 2017-10-22 09:07:55 PDT 
Attachment 324528 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/JIT.cpp:252:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JIT.cpp:261:  Almost always, snprintf is better than strcat.  [security/printf] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2017-10-22 09:11:52 PDT 
Comment on attachment 324528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324528&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        It is good since (1) we can reduce the manual emitting code and (2) it can clearify which

Typo: should be clarify
Comment 4 Yusuke Suzuki 2017-10-22 09:46:42 PDT 
Comment on attachment 324528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324528&action=review

>> Source/JavaScriptCore/ChangeLog:9
>> +        It is good since (1) we can reduce the manual emitting code and (2) it can clearify which
> 
> Typo: should be clarify

Thanks, fixed.
Comment 5 Yusuke Suzuki 2017-10-22 09:47:07 PDT 
Committed r223823: <https://trac.webkit.org/changeset/223823>
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:56:02 PST 
<rdar://problem/35568436>