RESOLVED FIXED 178646
[JSC] Clean up baseline slow path 
https://bugs.webkit.org/show_bug.cgi?id=178646
Summary [JSC] Clean up baseline slow path
Yusuke Suzuki
Reported 2017-10-22 09:04:26 PDT
[JSC] Clean up baseline slow path
Attachments
Patch (27.82 KB, patch)
2017-10-22 09:06 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-10-22 09:06:03 PDT
Created attachment 324528 [details] Patch
Build Bot
Comment 2 2017-10-22 09:07:55 PDT
Attachment 324528 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JIT.cpp:252: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JIT.cpp:261: Almost always, snprintf is better than strcat. [security/printf] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3 2017-10-22 09:11:52 PDT
Comment on attachment 324528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324528&action=review > Source/JavaScriptCore/ChangeLog:9 > + It is good since (1) we can reduce the manual emitting code and (2) it can clearify which Typo: should be clarify
Yusuke Suzuki
Comment 4 2017-10-22 09:46:42 PDT
Comment on attachment 324528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324528&action=review >> Source/JavaScriptCore/ChangeLog:9 >> + It is good since (1) we can reduce the manual emitting code and (2) it can clearify which > > Typo: should be clarify Thanks, fixed.
Yusuke Suzuki
Comment 5 2017-10-22 09:47:07 PDT
Committed r223823: <https://trac.webkit.org/changeset/223823>
Radar WebKit Bug Importer
Comment 6 2017-11-15 12:56:02 PST
<rdar://problem/35568436>
Note You need to log in before you can comment on or make changes to this bug.