Bug 178643 - [Web Animations] Add animations to the timeline
Summary: [Web Animations] Add animations to the timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-22 05:22 PDT by Antoine Quint
Modified: 2017-10-31 06:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.91 KB, patch)
2017-10-22 05:25 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (8.91 KB, patch)
2017-10-22 06:55 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (9.37 KB, patch)
2017-10-22 10:16 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-10-22 05:22:26 PDT
[Web Animations] Add animations to the timeline
Comment 1 Antoine Quint 2017-10-22 05:25:14 PDT
Created attachment 324524 [details]
Patch
Comment 2 Antoine Quint 2017-10-22 06:55:30 PDT
Created attachment 324525 [details]
Patch
Comment 3 Antoine Quint 2017-10-22 10:16:47 PDT
Created attachment 324529 [details]
Patch
Comment 4 Dean Jackson 2017-10-22 13:01:34 PDT
Comment on attachment 324529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324529&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:60
> +    stream << (m_classType == DocumentTimelineClass ? "DocumentTimeline" : "AnimationTimeline") << " with " << m_animations.size() << " animations:";
> +    stream << "\n";

why not put this on the previous line?

> Source/WebCore/animation/AnimationTimeline.cpp:64
> +        stream << count << ". " << animation->description();
> +        stream << "\n";

same
Comment 5 WebKit Commit Bot 2017-10-22 14:31:28 PDT
Comment on attachment 324529 [details]
Patch

Clearing flags on attachment: 324529

Committed r223825: <https://trac.webkit.org/changeset/223825>
Comment 6 WebKit Commit Bot 2017-10-22 14:31:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-31 06:40:53 PDT
<rdar://problem/35271075>