Bug 178619 - createImageBitmap with basic HTMLImageElement
Summary: createImageBitmap with basic HTMLImageElement
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2017-10-21 00:35 PDT by Dean Jackson
Modified: 2017-10-21 14:49 PDT (History)
7 users (show)

See Also:

Patch (18.21 KB, patch)
2017-10-21 00:41 PDT, Dean Jackson
graouts: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-10-21 00:35:26 PDT
createImageBitmap with basic HTMLImageElement
Comment 1 Dean Jackson 2017-10-21 00:36:24 PDT
Comment 2 Dean Jackson 2017-10-21 00:41:05 PDT
Created attachment 324497 [details]
Comment 3 Antoine Quint 2017-10-21 01:03:46 PDT
Comment on attachment 324497 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=324497&action=review

> Source/WebCore/html/ImageBitmap.cpp:133
> +    // FIXME: Move this into a separate function and handle the cropping/resizing.

Could use a bugzilla bug here.

> LayoutTests/http/wpt/common/canvas-tests.js:35
> +function _assertPixel(canvas, x,y, r,g,b,a, pos, colour)

I'm pretty sure it's "color"
Comment 4 Dean Jackson 2017-10-21 14:49:28 PDT
Committed r223819: <https://trac.webkit.org/changeset/223819>