Bug 178617 - Web Inspector: Remove unused Console.setMonitoringXHREnabled
Summary: Web Inspector: Remove unused Console.setMonitoringXHREnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
: 155688 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-10-20 23:31 PDT by Joseph Pecoraro
Modified: 2017-11-15 12:58 PST (History)
16 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (15.38 KB, patch)
2017-10-20 23:42 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (17.29 KB, patch)
2017-10-20 23:57 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (26.70 KB, patch)
2017-10-21 00:07 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (26.71 KB, patch)
2017-10-21 00:10 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Fix Windows (35.21 KB, patch)
2017-10-23 09:54 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-10-20 23:31:34 PDT 
Remove unused Console.setMonitoringXHREnabled

* This hasn't ever been used by our frontend.
* It shouldn't exist on Console. It is a Web concept.
* It can be done in other ways and isn't needed here.
Comment 1 Joseph Pecoraro 2017-10-20 23:41:42 PDT 
*** Bug 155688 has been marked as a duplicate of this bug. ***
Comment 2 Joseph Pecoraro 2017-10-20 23:42:39 PDT 
Created attachment 324491 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2017-10-20 23:57:30 PDT 
Created attachment 324493 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2017-10-21 00:02:07 PDT 
Comment on attachment 324493 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=324493&action=review

> Source/JavaScriptCore/inspector/agents/JSGlobalObjectConsoleAgent.h:37
>      JSGlobalObjectConsoleAgent(AgentContext&, InspectorHeapAgent*);
>      virtual ~JSGlobalObjectConsoleAgent() { }

Actually I don't think this needs to be virtual anymore! Let me do a  little more cleanup.
Comment 5 Joseph Pecoraro 2017-10-21 00:07:39 PDT 
Created attachment 324494 [details]
[PATCH] Proposed Fix

Get to remove more and more and more!
Comment 6 Joseph Pecoraro 2017-10-21 00:10:24 PDT 
Created attachment 324495 [details]
[PATCH] Proposed Fix
Comment 7 WebKit Commit Bot 2017-10-21 15:23:05 PDT 
Comment on attachment 324495 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 324495

Committed r223820: <https://trac.webkit.org/changeset/223820>
Comment 8 WebKit Commit Bot 2017-10-21 15:23:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Matt Lewis 2017-10-23 09:45:03 PDT 
Reverted r223820 for reason:

This caused a build break on Windows.

Committed r223836: <https://trac.webkit.org/changeset/223836>
Comment 11 BJ Burg 2017-10-23 09:54:40 PDT 
Created attachment 324562 [details]
Fix Windows
Comment 12 BJ Burg 2017-10-23 17:55:57 PDT 
Committed r223868: <https://trac.webkit.org/changeset/223868>
Comment 13 Radar WebKit Bug Importer 2017-11-15 12:58:13 PST 
<rdar://problem/35568507>