Bug 178609 – [Payment Request] Resolve PaymentRequest.show()'s accept promise when a payment is authorized

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Payment Request] Resolve PaymentRequest.show()'s accept promise when a payment is authorized

[Andy Estes]

Created attachment 324468 [details]
Patch

[Build Bot]

Attachment 324468 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:74:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 324468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324468&action=review

> Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:287
> +    auto address = PaymentAddress::create();
> +    address->setCountry(contact.countryCode);

Could we make a constructor that takes these values so if we add one later we won't forget to add setters in all the necessary places?

> Source/WebCore/Modules/paymentrequest/PaymentAddress.h:38
> +    static Ref<PaymentAddress> create()

Yeah, let's add a meaningful constructor instead of a bunch of setters.

[Andy Estes]

Created attachment 324576 [details]
Patch

[Andy Estes]

rdar://problem/33542813

[WebKit Commit Bot]

Comment on attachment 324576 [details]
Patch

Rejecting attachment 324576 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 324576, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 file LayoutTests/http/tests/paymentrequest/payment-response-payerName-attribute.https.html
patching file LayoutTests/http/tests/paymentrequest/payment-response-payerPhone-attribute.https-expected.txt
patching file LayoutTests/http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html
patching file LayoutTests/http/tests/paymentrequest/resources/helpers.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4960745

[Andy Estes]

Created attachment 324582 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 324582 [details]
Patch

Clearing flags on attachment: 324582

Committed r223855: <https://trac.webkit.org/changeset/223855>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.