Bug 178608 – Cleanup unnecessary code to run JavaScriptCore tests

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Tools / Tests

[Aakash Jain]

We now have a separate JavaScriptCore test EWS which run JavaScriptCore tests on every patch (as appropriate).

There seems to be unnecessary code in runtests.py to run JavaScriptCore tests which is enabled only when --non-interactive mode is not passed. All of the EWSes seems to pass --non-interactive (in patchanalysistask.py base class _test() method). So this seems unnecessary code.

[Aakash Jain]

Created attachment 324465 [details]
Proposed patch

[Daniel Bates]

(In reply to Aakash Jain from comment #0)
> We now have a separate JavaScriptCore test EWS which run JavaScriptCore
> tests on every patch (as appropriate).
> 
> There seems to be unnecessary code in runtests.py to run JavaScriptCore
> tests which is enabled only when --non-interactive mode is not passed.

This is incorrect. We run these test when running webkit-patch interactively by <https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py?rev=223796#L94> 

> All of the EWSes seems to pass --non-interactive (in patchanalysistask.py base
> class _test() method). So this seems unnecessary code.

[Daniel Bates]

Comment on attachment 324465 [details]
Proposed patch

This will make "webkit-patch build-and-test" and "webkit-patch build-and-test-attachment " no longer run the JavaScriptCore tests.

[Alexey Proskuryakov]

Who uses webkit-patch like this? This particular tiny test suite is not very valuable to run for each and every patch locally, and thus I find it unlikely that anyone manually uses the command that forces it.

[Aakash Jain]

This portion of code does not affect EWS since EWS pass the option --non-interactive. We can keep this code as it would be executed when someone manually executes "webkit-patch build-and-test".