Bug 178607 - Fix conditions in HTMLSourceElement and HTMLTrackElement's insertedInto and removedFrom
Summary: Fix conditions in HTMLSourceElement and HTMLTrackElement's insertedInto and r...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Keywords: InRadar
Depends on:
Reported: 2017-10-20 16:10 PDT by Ryosuke Niwa
Modified: 2017-11-15 13:01 PST (History)
8 users (show)

See Also:

Cleanup (4.49 KB, patch)
2017-10-20 16:15 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Wrote change log (4.85 KB, patch)
2017-10-20 16:19 PDT, Ryosuke Niwa
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-10-20 16:10:18 PDT
Right now, HTMLSourceElement and HTMLTrackElement's insertedInto and removedFrom contain obviously wrong code.
Fix them as I've learned these elements are only effective when they're a direct child of HTMLMediaElement.
Comment 1 Ryosuke Niwa 2017-10-20 16:15:49 PDT
Created attachment 324462 [details]
Comment 2 Build Bot 2017-10-20 16:17:28 PDT
Attachment 324462 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2017-10-20 16:19:53 PDT
Created attachment 324463 [details]
Wrote change log
Comment 4 Ryosuke Niwa 2017-10-20 16:51:41 PDT
Thanks for the review!
Comment 5 Ryosuke Niwa 2017-10-20 17:03:20 PDT
Committed r223801: <https://trac.webkit.org/changeset/223801>
Comment 6 Radar WebKit Bug Importer 2017-11-15 13:01:45 PST