Bug 178606 - http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin.html is flaky
Summary: http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-orig...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Keywords: InRadar
Depends on:
Reported: 2017-10-20 16:07 PDT by Matt Lewis
Modified: 2017-11-15 12:58 PST (History)
3 users (show)

See Also:

Fixes the bug (2.12 KB, patch)
2017-10-20 16:49 PDT, Ryosuke Niwa
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-10-20 16:07:07 PDT
http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin.html is a flaky failure according to the dashboard.



--- /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin-actual.txt
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: line 233: Blocked a frame with origin "" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
 This tests draggin and dropping HTML by the default action. WebKit should not sanitize the HTML in the same document.
 To manually test, drag & drop the content in the block above to the blue box on the right.
@@ -17,7 +16,7 @@
 PASS destination.innerHTML.includes("dangerousCode") is false
 PASS destination.querySelector("img"); !!img is true
 PASS new URL(img.src).protocol is "http:"
-PASS destination.querySelector("iframe").contentDocument is null
+FAIL destination.querySelector("iframe").contentDocument should be null. Was [object HTMLDocument].
 PASS successfullyParsed is true

This was flaky on WK1 since it was added
Comment 1 Ryosuke Niwa 2017-10-20 16:49:39 PDT
Created attachment 324467 [details]
Fixes the bug
Comment 2 Wenson Hsieh 2017-10-20 16:51:44 PDT
Comment on attachment 324467 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=324467&action=review

> LayoutTests/ChangeLog:10
> +        Waiting for message event wasn't doing anything useful because it was receivinv the message from

receivinv => receiving
Comment 3 Ryosuke Niwa 2017-10-20 16:55:40 PDT
Committed r223800: <https://trac.webkit.org/changeset/223800>
Comment 4 Radar WebKit Bug Importer 2017-11-15 12:58:34 PST