RESOLVED FIXED 178606
http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=178606
Summary http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-orig...
Matt Lewis
Reported 2017-10-20 16:07:07 PDT
http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin.html is a flaky failure according to the dashboard. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fclipboard%2Fdrag-drop-html-cross-origin-iframe-in-same-origin.html https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r223795%20(5616)/results.html https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/builds/5616 --- /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin-expected.txt +++ /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin-actual.txt @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: line 233: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. This tests draggin and dropping HTML by the default action. WebKit should not sanitize the HTML in the same document. To manually test, drag & drop the content in the block above to the blue box on the right. @@ -17,7 +16,7 @@ PASS destination.innerHTML.includes("dangerousCode") is false PASS destination.querySelector("img"); !!img is true PASS new URL(img.src).protocol is "http:" -PASS destination.querySelector("iframe").contentDocument is null +FAIL destination.querySelector("iframe").contentDocument should be null. Was [object HTMLDocument]. PASS successfullyParsed is true TEST COMPLETE This was flaky on WK1 since it was added
Attachments
Fixes the bug (2.12 KB, patch)
2017-10-20 16:49 PDT, Ryosuke Niwa
wenson_hsieh: review+
Ryosuke Niwa
Comment 1 2017-10-20 16:49:39 PDT
Created attachment 324467 [details] Fixes the bug
Wenson Hsieh
Comment 2 2017-10-20 16:51:44 PDT
Comment on attachment 324467 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=324467&action=review > LayoutTests/ChangeLog:10 > + Waiting for message event wasn't doing anything useful because it was receivinv the message from receivinv => receiving
Ryosuke Niwa
Comment 3 2017-10-20 16:55:40 PDT
Radar WebKit Bug Importer
Comment 4 2017-11-15 12:58:34 PST
Note You need to log in before you can comment on or make changes to this bug.