Bug 178604 - [FrameView::layout cleanup] Use SetForScope to ensure layout state correctness
Summary: [FrameView::layout cleanup] Use SetForScope to ensure layout state correctness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-20 14:08 PDT by zalan
Modified: 2017-10-20 21:31 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.21 KB, patch)
2017-10-20 14:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.21 MB, application/zip)
2017-10-20 15:32 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.88 MB, application/zip)
2017-10-20 15:50 PDT, Build Bot 		no flags Details
Patch (13.03 KB, patch)
2017-10-20 20:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-20 14:08:04 PDT 
with nested layout calls.
Comment 1 Radar WebKit Bug Importer 2017-10-20 14:08:36 PDT 
<rdar://problem/35101890>
Comment 2 zalan 2017-10-20 14:26:57 PDT 
Created attachment 324446 [details]
Patch
Comment 3 Build Bot 2017-10-20 15:32:25 PDT 
Comment on attachment 324446 [details]
Patch

Attachment 324446 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4937213

New failing tests:
fast/css-grid-layout/flex-content-sized-columns-resize.html
Comment 4 Build Bot 2017-10-20 15:32:26 PDT 
Created attachment 324452 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-10-20 15:50:12 PDT 
Comment on attachment 324446 [details]
Patch

Attachment 324446 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4937255

New failing tests:
fast/css-grid-layout/flex-content-sized-columns-resize.html
Comment 6 Build Bot 2017-10-20 15:50:13 PDT 
Created attachment 324455 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 zalan 2017-10-20 20:55:26 PDT 
Created attachment 324483 [details]
Patch
Comment 8 WebKit Commit Bot 2017-10-20 21:31:50 PDT 
Comment on attachment 324483 [details]
Patch

Clearing flags on attachment: 324483

Committed r223805: <https://trac.webkit.org/changeset/223805>
Comment 9 WebKit Commit Bot 2017-10-20 21:31:52 PDT 
All reviewed patches have been landed.  Closing bug.