We now have a separate bindings test EWS which run bindings-tests on every patch (as appropriate). Currently all the EWSes which run tests also run bindings tests, but ignore it's output. There is no point in running these tests and ignoring the output. We should remove this old code.
This is also inefficient to run tests unnecessarily(and ignoring their result). This adds running time to multiple EWSes (which run tests) with no benefit.
Created attachment 324433 [details] Proposed patch
This fails webkitpy tests. I need to update them. That's why we need https://bugs.webkit.org/show_bug.cgi?id=178480
Created attachment 324445 [details] Patch with updated unit-tests
Comment on attachment 324445 [details] Patch with updated unit-tests Clearing flags on attachment: 324445 Committed r223796: <https://trac.webkit.org/changeset/223796>
All reviewed patches have been landed. Closing bug.
(In reply to WebKit Commit Bot from comment #5) > Comment on attachment 324445 [details] > Patch with updated unit-tests > > Clearing flags on attachment: 324445 > > Committed r223796: <https://trac.webkit.org/changeset/223796> This change means that "webkit-patch build-and-test" and "webkit-patch build-and-test-attachment" no longer run the bindings tests. These commands exist as a convenience to build a patch and run all the test suites we have. I do not see the need to remove such convenience especially given that we have so many test suites.
Is this actually how people use webkit-patch?
<rdar://problem/35568567>