Bug 178593 - ResourceResponse should have a ServiceWorker source
Summary: ResourceResponse should have a ServiceWorker source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-20 10:46 PDT by youenn fablet
Modified: 2017-11-15 13:05 PST (History)
8 users (show)

See Also:


Attachments
Patch (12.78 KB, patch)
2017-10-20 11:13 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (12.83 KB, patch)
2017-10-20 11:54 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-10-20 10:46:59 PDT
This will be useful for testing and for inspector.
Comment 1 youenn fablet 2017-10-20 11:13:54 PDT
Created attachment 324419 [details]
Patch
Comment 2 Joseph Pecoraro 2017-10-20 11:20:34 PDT
Comment on attachment 324419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324419&action=review

> Source/WebCore/inspector/InspectorNetworkAgent.cpp:279
> +    // FIXME: Add an Inspector ServiceWorker source.
> +    case ResourceResponse::Source::ServiceWorker:
> +        return Inspector::Protocol::Network::Response::Source::Unknown;

Please file a bugzilla bug and assign it to me. FIXME's like this getting added to Inspector code are easy to get lost if there isn't a real bug with engineers CC'd to know about it!
Comment 3 youenn fablet 2017-10-20 11:54:13 PDT
Created attachment 324423 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-10-20 12:42:23 PDT
Comment on attachment 324423 [details]
Patch for landing

Clearing flags on attachment: 324423

Committed r223785: <https://trac.webkit.org/changeset/223785>
Comment 5 WebKit Commit Bot 2017-10-20 12:42:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 13:05:52 PST
<rdar://problem/35568778>