Bug 178579 - [GTK][WPE] generate-forwarding-headers.pl should also scan derived sources in WebKit framework
Summary: [GTK][WPE] generate-forwarding-headers.pl should also scan derived sources in...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 179055
Blocks: 178574
  Show dependency treegraph
 
Reported: 2017-10-20 05:39 PDT by Zan Dobersek
Modified: 2017-10-31 07:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.00 KB, patch)
2017-10-20 06:55 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-10-20 05:39:21 PDT
[GTK][WPE] generate-forwarding-headers.pl should also scan derived WK2 sources
Comment 1 Zan Dobersek 2017-10-20 06:55:37 PDT
Created attachment 324392 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-10-23 23:53:09 PDT
Comment on attachment 324392 [details]
Patch

Thanks! I guess you have tried this with both clean and incremental builds.
Comment 3 Zan Dobersek 2017-10-24 01:17:16 PDT
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 324392 [details]
> Patch
> 
> Thanks! I guess you have tried this with both clean and incremental builds.

Yes.
Comment 4 Zan Dobersek 2017-10-24 01:20:05 PDT
Comment on attachment 324392 [details]
Patch

Clearing flags on attachment: 324392

Committed r223884: <https://trac.webkit.org/changeset/223884>
Comment 5 Zan Dobersek 2017-10-24 01:20:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2017-10-31 07:42:27 PDT
Re-opened since this is blocked by bug 179055
Comment 7 Konstantin Tokarev 2017-10-31 07:47:07 PDT
Why is it needed? Isn't writing generated files to the correct place sufficient? Generating header for generated header sounds redundant.