and not just for a subset of the layout. a scheduled layout would indicated a dirty tree (which is incorrect as we are supposed to leave ::layout with a clean tree)
<rdar://problem/35089015>
Created attachment 324342 [details] Patch
Comment on attachment 324342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324342&action=review > Source/WebCore/ChangeLog:9 > + A scheduled layout at the end of FrameView::layout would indicated dirty tree (which is against FrameView::layout's contract). would indicate a dirty tree (which is against the FrameView::layout's contract). You seem to have just lengthened the scope of changeSchedulingEnabled by outdenting code; is this comment just saying that it's OK for the scope to last to the end of the function?
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 324342 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324342&action=review > > > Source/WebCore/ChangeLog:9 > > + A scheduled layout at the end of FrameView::layout would indicated dirty tree (which is against FrameView::layout's contract). > > would indicate a dirty tree (which is against the FrameView::layout's > contract). > > You seem to have just lengthened the scope of changeSchedulingEnabled by > outdenting code; is this comment just saying that it's OK for the scope to > last to the end of the function? Correct.
Created attachment 324402 [details] Patch
Comment on attachment 324402 [details] Patch Clearing flags on attachment: 324402 Committed r223792: <https://trac.webkit.org/changeset/223792>
All reviewed patches have been landed. Closing bug.