RESOLVED FIXED 178562
[FrameView::layout cleanup] Scheduling layout should be disabled for FrameView::layout 
https://bugs.webkit.org/show_bug.cgi?id=178562
Summary [FrameView::layout cleanup] Scheduling layout should be disabled for FrameVie...
zalan
Reported 2017-10-19 20:22:09 PDT
and not just for a subset of the layout. a scheduled layout would indicated a dirty tree (which is incorrect as we are supposed to leave ::layout with a clean tree)
Attachments
Patch (9.26 KB, patch)
2017-10-19 20:38 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.90 KB, patch)
2017-10-20 08:30 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-19 20:22:42 PDT
<rdar://problem/35089015>
zalan
Comment 2 2017-10-19 20:38:44 PDT
Created attachment 324342 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-10-19 22:24:49 PDT
Comment on attachment 324342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324342&action=review > Source/WebCore/ChangeLog:9 > + A scheduled layout at the end of FrameView::layout would indicated dirty tree (which is against FrameView::layout's contract). would indicate a dirty tree (which is against the FrameView::layout's contract). You seem to have just lengthened the scope of changeSchedulingEnabled by outdenting code; is this comment just saying that it's OK for the scope to last to the end of the function?
zalan
Comment 4 2017-10-19 22:35:41 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 324342 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324342&action=review > > > Source/WebCore/ChangeLog:9 > > + A scheduled layout at the end of FrameView::layout would indicated dirty tree (which is against FrameView::layout's contract). > > would indicate a dirty tree (which is against the FrameView::layout's > contract). > > You seem to have just lengthened the scope of changeSchedulingEnabled by > outdenting code; is this comment just saying that it's OK for the scope to > last to the end of the function? Correct.
zalan
Comment 5 2017-10-20 08:30:02 PDT
Created attachment 324402 [details] Patch
WebKit Commit Bot
Comment 6 2017-10-20 13:40:27 PDT
Comment on attachment 324402 [details] Patch Clearing flags on attachment: 324402 Committed r223792: <https://trac.webkit.org/changeset/223792>
WebKit Commit Bot
Comment 7 2017-10-20 13:40:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.