Bug 178561 - Move common bindings files to unified sources
Summary: Move common bindings files to unified sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-19 20:18 PDT by Keith Miller
Modified: 2017-11-15 13:01 PST (History)
9 users (show)

See Also:


Attachments
Patch (562.82 KB, patch)
2017-10-19 20:21 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (582.60 KB, patch)
2017-10-19 22:13 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (582.43 KB, patch)
2017-10-19 22:17 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (582.65 KB, patch)
2017-10-19 22:23 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (582.65 KB, patch)
2017-10-19 22:28 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (583.18 KB, patch)
2017-10-19 23:31 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (583.19 KB, patch)
2017-10-19 23:33 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (584.97 KB, patch)
2017-10-19 23:41 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-10-19 20:18:50 PDT
Move common bindings files to unified sources
Comment 1 Keith Miller 2017-10-19 20:21:08 PDT
Created attachment 324338 [details]
Patch
Comment 2 Keith Miller 2017-10-19 22:13:03 PDT
Created attachment 324352 [details]
Patch
Comment 3 Keith Miller 2017-10-19 22:17:40 PDT
Created attachment 324353 [details]
Patch
Comment 4 Keith Miller 2017-10-19 22:23:45 PDT
Created attachment 324354 [details]
Patch
Comment 5 Keith Miller 2017-10-19 22:28:50 PDT
Created attachment 324356 [details]
Patch
Comment 6 Ryosuke Niwa 2017-10-19 22:33:10 PDT
Comment on attachment 324356 [details]
Patch

rs=me
Comment 7 Keith Miller 2017-10-19 23:31:47 PDT
Created attachment 324360 [details]
Patch
Comment 8 Keith Miller 2017-10-19 23:33:57 PDT
Created attachment 324361 [details]
Patch
Comment 9 Keith Miller 2017-10-19 23:41:54 PDT
Created attachment 324363 [details]
Patch
Comment 10 WebKit Commit Bot 2017-10-20 00:50:33 PDT
Comment on attachment 324363 [details]
Patch

Clearing flags on attachment: 324363

Committed r223747: <https://trac.webkit.org/changeset/223747>
Comment 11 WebKit Commit Bot 2017-10-20 00:50:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Matt Lewis 2017-10-20 12:26:42 PDT
This revision cause a build break in windows:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5397
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5397/steps/compile-webkit/logs/stdio


error:
CMake Error at Source/cmake/WebKitMacros.cmake:128 (add_library):
  Cannot find source file:

    C:/cygwin/home/buildbot/slave/win-release/build/WebKitBuild/Release/DerivedSources/WebCore/UserAgentScriptsData.cpp
Comment 13 Radar WebKit Bug Importer 2017-11-15 13:01:20 PST
<rdar://problem/35568620>