Bug 178558 - [FrameView::layout cleanup] Move style update related logic to a separate function
Summary: [FrameView::layout cleanup] Move style update related logic to a separate fun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-19 19:19 PDT by zalan
Modified: 2017-10-19 21:52 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.61 KB, patch)
2017-10-19 19:28 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.47 KB, patch)
2017-10-19 21:22 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-19 19:19:22 PDT 
ssia
Comment 1 Radar WebKit Bug Importer 2017-10-19 19:19:49 PDT 
<rdar://problem/35088218>
Comment 2 zalan 2017-10-19 19:28:07 PDT 
Created attachment 324333 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-10-19 20:25:27 PDT 
Comment on attachment 324333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324333&action=review

> Source/WebCore/page/FrameView.cpp:1365
> +void FrameView::ensureStyleIsUpToDateForLayout()

Maybe just updateStyleForLayout or updateStyleBeforeLayout ?
Comment 4 zalan 2017-10-19 21:22:43 PDT 
Created attachment 324348 [details]
Patch
Comment 5 WebKit Commit Bot 2017-10-19 21:52:10 PDT 
Comment on attachment 324348 [details]
Patch

Clearing flags on attachment: 324348

Committed r223742: <https://trac.webkit.org/changeset/223742>
Comment 6 WebKit Commit Bot 2017-10-19 21:52:11 PDT 
All reviewed patches have been landed.  Closing bug.