Bug 178552 - ServiceWorkerContextManager should be an IPC::MessageReceiver
Summary: ServiceWorkerContextManager should be an IPC::MessageReceiver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 178534
  Show dependency tree / graph
 
Reported: 2017-10-19 16:42 PDT by Chris Dumez
Modified: 2017-11-15 13:00 PST (History)
5 users (show)

See Also:

Attachments
Patch (24.22 KB, patch)
2017-10-19 16:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (24.79 KB, patch)
2017-10-19 16:46 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (24.53 KB, patch)
2017-10-19 18:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-19 16:42:25 PDT 
ServiceWorkerContextManager should be an IPC::MessageReceiver, to avoid putting too many ServiceWorker related methods on WebProcess class.
Comment 1 Chris Dumez 2017-10-19 16:45:48 PDT 
Created attachment 324315 [details]
Patch
Comment 2 Chris Dumez 2017-10-19 16:46:46 PDT 
Created attachment 324316 [details]
Patch
Comment 3 youenn fablet 2017-10-19 17:14:22 PDT 
Comment on attachment 324316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324316&action=review

> Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.messages.in:27
> +    StartFetchInServiceWorker(uint64_t serverConnectionIdentifier, uint64_t fetchIdentifier, uint64_t serviceWorkerIdentifier, WebCore::ResourceRequest request, struct WebCore::FetchOptions options)

Can we rename these to StartWorker and Fetch since they are now scoped by ServiceWorkerContextManager?

> Source/WebKit/WebProcess/WebProcess.cpp:665
>  

#if ENABLE(SERVICE_WORKER) probably

> Source/WebKit/WebProcess/WebProcess.cpp:667
> +        if (m_serviceWorkerManager)

Can you add ASSERT(m_serviceWorkerManager);
Comment 4 Chris Dumez 2017-10-19 18:38:17 PDT 
Created attachment 324327 [details]
Patch
Comment 5 Chris Dumez 2017-10-19 19:40:03 PDT 
Comment on attachment 324327 [details]
Patch

Clearing flags on attachment: 324327

Committed r223739: <https://trac.webkit.org/changeset/223739>
Comment 6 Chris Dumez 2017-10-19 19:40:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 13:00:42 PST 
<rdar://problem/35568595>