Bug 178550 - SerializedScriptValue passed to postMessage() cannot be null
Summary: SerializedScriptValue passed to postMessage() cannot be null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-19 16:20 PDT by Chris Dumez
Modified: 2017-11-15 13:01 PST (History)
9 users (show)

See Also:

Attachments
Patch (8.74 KB, patch)
2017-10-19 16:21 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-19 16:20:48 PDT 
SerializedScriptValue passed to postMessage() cannot be null. Therefore, we should use Ref<> type, not RefPtr<>.
Comment 1 Chris Dumez 2017-10-19 16:21:49 PDT 
Created attachment 324310 [details]
Patch
Comment 2 youenn fablet 2017-10-19 16:26:02 PDT 
Comment on attachment 324310 [details]
Patch

Would be cool to move from unique_ptr to UniqueRef as well.
Comment 3 Chris Dumez 2017-10-19 16:35:27 PDT 
(In reply to youenn fablet from comment #2)
> Comment on attachment 324310 [details]
> Patch
> 
> Would be cool to move from unique_ptr to UniqueRef as well.

Channels can be nullptr.
Comment 4 Chris Dumez 2017-10-19 18:34:07 PDT 
Comment on attachment 324310 [details]
Patch

Clearing flags on attachment: 324310

Committed r223732: <https://trac.webkit.org/changeset/223732>
Comment 5 Chris Dumez 2017-10-19 18:34:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 13:01:06 PST 
<rdar://problem/35568614>