178547 – Modernize API::DownloadClient

Bug 178547 - Modernize API::DownloadClient

Summary: Modernize API::DownloadClient

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alex Christensen

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-10-19 15:25 PDT by Alex Christensen
Modified:	2017-11-15 13:03 PST (History)
CC List:	8 users (show)

See Also:

Attachments
Patch (46.61 KB, patch) 2017-10-19 15:31 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (46.76 KB, patch) 2017-10-19 15:46 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (50.57 KB, patch) 2017-10-19 16:43 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Christensen 2017-10-19 15:25:49 PDT

Modernize API::DownloadClient

Comment 1 Alex Christensen 2017-10-19 15:31:38 PDT

Created attachment 324302 [details]
Patch

Comment 2 Alex Christensen 2017-10-19 15:46:40 PDT

Created attachment 324305 [details]
Patch

Comment 3 Build Bot 2017-10-19 15:49:58 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 4 Andy Estes 2017-10-19 15:56:31 PDT

Comment on attachment 324305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324305&action=review

> Source/WebKit/UIProcess/API/APIDownloadClient.h:42
> +enum class AllowOverwrite { No, Yes };

Kinda weird to put this in the place where we're forward declaring things.

Comment 5 Alex Christensen 2017-10-19 16:43:05 PDT

Created attachment 324314 [details]
Patch

Comment 6 Alex Christensen 2017-10-19 17:09:54 PDT

http://trac.webkit.org/r223730

Comment 7 Matt Lewis 2017-10-20 14:59:16 PDT

This revision caused several tests to fail consistently on El Capitan:
     http/tests/download/anchor-download-no-extension.html
     http/tests/download/anchor-download-redirect.html
     http/tests/download/anchor-download-redirect.html
     http/tests/security/anchor-download-allow-sameorigin.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fdownload%2Fanchor-download-no-extension.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fdownload%2Fanchor-download-redirect.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fdownload%2Farea-download.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fanchor-download-allow-sameorigin.html

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r223778%20(3750)/results.html

Comment 8 Alex Christensen 2017-10-20 16:12:22 PDT

http://trac.webkit.org/r223798

Comment 9 Radar WebKit Bug Importer 2017-11-15 13:03:38 PST

<rdar://problem/35568704>