RESOLVED FIXED 178547
Modernize API::DownloadClient 
https://bugs.webkit.org/show_bug.cgi?id=178547
Summary Modernize API::DownloadClient
Alex Christensen
Reported 2017-10-19 15:25:49 PDT
Modernize API::DownloadClient
Attachments
Patch (46.61 KB, patch)
2017-10-19 15:31 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (46.76 KB, patch)
2017-10-19 15:46 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (50.57 KB, patch)
2017-10-19 16:43 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-10-19 15:31:38 PDT
Created attachment 324302 [details] Patch
Alex Christensen
Comment 2 2017-10-19 15:46:40 PDT
Created attachment 324305 [details] Patch
Build Bot
Comment 3 2017-10-19 15:49:58 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Andy Estes
Comment 4 2017-10-19 15:56:31 PDT
Comment on attachment 324305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324305&action=review > Source/WebKit/UIProcess/API/APIDownloadClient.h:42 > +enum class AllowOverwrite { No, Yes }; Kinda weird to put this in the place where we're forward declaring things.
Alex Christensen
Comment 5 2017-10-19 16:43:05 PDT
Created attachment 324314 [details] Patch
Alex Christensen
Comment 6 2017-10-19 17:09:54 PDT
http://trac.webkit.org/r223730
Alex Christensen
Comment 8 2017-10-20 16:12:22 PDT
http://trac.webkit.org/r223798
Radar WebKit Bug Importer
Comment 9 2017-11-15 13:03:38 PST
<rdar://problem/35568704>
Note You need to log in before you can comment on or make changes to this bug.