Bug 178542 – Generated serializers do not properly handle optional interface attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

Generated serializers do not properly handle optional interface attributes

[Andy Estes]

Created attachment 324285 [details]
Patch

[Build Bot]

Attachment 324285 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 324285 [details]
Patch

Attachment 324285 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/4923813

New failing tests:
(JS) JSTestSerialization.cpp

[Andy Estes]

Created attachment 324412 [details]
Patch

[Sam Weinig]

Comment on attachment 324412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324412&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5260
> +                push(@implContent, "        ASSERT(!${name}Value.isUndefined());\n");

I don't think this is necessary.

[Andy Estes]

Created attachment 324421 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 324421 [details]
Patch

Clearing flags on attachment: 324421

Committed r223780: <https://trac.webkit.org/changeset/223780>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568705>