Bug 178538 – [FrameView::layout cleanup] Move post layout task scheduling logic to a separate function

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/35080743>

[zalan]

Created attachment 324277 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 324277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324277&action=review

> Source/WebCore/page/FrameView.cpp:1568
> +    // If we are already in a synchronous call, defer post layout tasks until after we return.

blank line above.

> Source/WebCore/page/FrameView.cpp:1569
> +    // Post layout taks can make us need to update again, and we can get stuck in a cycle.

The following call to performPostLayoutTasks can cause this function to get re-entered. We use the timer to prevent re-entrancy.

> Source/WebCore/page/FrameView.cpp:1574
> +    performPostLayoutTasks();

blank line above

> Source/WebCore/page/FrameView.cpp:1576
> +        // Post layout widget tasks made us need layout again.

Remove this line.

> Source/WebCore/page/FrameView.h:692
>      void performPostLayoutTasks();
> +    void runOrSchedulePostLayoutTasks();

Maybe swap.

[zalan]

Created attachment 324282 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 324282 [details]
Patch

Clearing flags on attachment: 324282

Committed r223717: <https://trac.webkit.org/changeset/223717>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.