Bug 178532 - re-inline ObjectAllocationProfile::initializeProfile
Summary: re-inline ObjectAllocationProfile::initializeProfile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-19 12:24 PDT by Saam Barati
Modified: 2017-11-15 13:02 PST (History)
14 users (show)

See Also:

Attachments
patch (21.77 KB, patch)
2017-10-19 14:50 PDT, Saam Barati 		msaboff: review+
Details | Formatted Diff | Diff
patch for landing (21.99 KB, patch)
2017-10-19 14:56 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-10-19 12:24:49 PDT 
I un-inlined this when doing poly proto. I think there are contexts where inlining this actually turns the function into very few instructions.
Comment 1 Saam Barati 2017-10-19 14:50:59 PDT 
Created attachment 324296 [details]
patch
Comment 2 Michael Saboff 2017-10-19 14:51:54 PDT 
Comment on attachment 324296 [details]
patch

rs=me
Comment 3 Saam Barati 2017-10-19 14:52:22 PDT 
Comment on attachment 324296 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324296&action=review

> Source/JavaScriptCore/bytecode/ObjectAllocationProfileInlines.h:25
> +

OOPS I'm missing pragma once. Will add
Comment 4 Build Bot 2017-10-19 14:52:43 PDT 
Attachment 324296 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/ObjectAllocationProfileInlines.h:26:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/bytecode/ObjectAllocationProfileInlines.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Saam Barati 2017-10-19 14:56:37 PDT 
Created attachment 324298 [details]
patch for landing
Comment 6 Build Bot 2017-10-19 14:58:32 PDT 
Attachment 324298 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/ObjectAllocationProfileInlines.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2017-10-19 16:34:28 PDT 
Comment on attachment 324298 [details]
patch for landing

Clearing flags on attachment: 324298

Committed r223727: <https://trac.webkit.org/changeset/223727>
Comment 8 WebKit Commit Bot 2017-10-19 16:34:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-11-15 13:02:22 PST 
<rdar://problem/35568665>