Bug 178528 – Use "= default" to denote default constructor or destructor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Use "= default" to denote default constructor or destructor instead of defining an empty function. This helps makes default constructors/destructors stand out from other functions as well as makes them searchable.

[Daniel Bates]

Created attachment 324261 [details]
Patch

This a large change. ItIt is entirely mechanical. Mark default constructors and destructors with "= default" and remove their body. With the exception of Payment.h I left unnecesary explicit declarations of constructors and destructors in the code to keep this patch as consistent as possible to hopefully make it easy to review. In a follow up patch we can remove such declarations as the compiler will generate these functions for us.

[Daniel Bates]

Committed r223728: <https://trac.webkit.org/changeset/223728>

[Joseph Pecoraro]

Is there an advantage to this?

[Daniel Bates]

(In reply to Joseph Pecoraro from comment #3)
> Is there an advantage to this?

https://stackoverflow.com/questions/20828907/the-new-keyword-default-in-c11

[Joseph Pecoraro]

(In reply to Daniel Bates from comment #4)
> (In reply to Joseph Pecoraro from comment #3)
> > Is there an advantage to this?
> 
> https://stackoverflow.com/questions/20828907/the-new-keyword-default-in-c11

Thanks.

Something to this effect should absolutely have been in the ChangeLog explaining why this change was made.

The reason stated in the bugzilla bug was "This helps makes default constructors/destructors stand out from other functions as well as makes them searchable." which is not the same justification as the link you provided, nor would I necessarily agree with it. But using `= default` to make some classes be treated as POD / Trivial is an observable change that we might benefit from.

[Radar WebKit Bug Importer]

<rdar://problem/35568661>