Bug 178527 – Service Worker process should not be selected to open WebView on it

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Currently service worker process is a web process.
In the future, we might want it to have a dedicated type.
In the meantime, it should not be selected to open WebView on it

[youenn fablet]

Created attachment 324256 [details]
Patch

[Chris Dumez]

Comment on attachment 324256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324256&action=review

r=me with comments.

> Source/WebKit/UIProcess/WebProcessPool.cpp:940
> +    Vector<std::reference_wrapper<WebProcessProxy>> processes;

I think processes is too generic, how about reusableProcesses ?

> Source/WebKit/UIProcess/WebProcessPool.cpp:944
> +        if (isMatchingStore && (process.get() != m_workerContextProcess))

You're going to need to protect the second check behind a #if ENABLE(SERVICE_WORKER)

[youenn fablet]

Created attachment 324271 [details]
Patch

[Chris Dumez]

Comment on attachment 324271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324271&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:940
> +    WebProcessProxy* reusableProcess = nullptr;

I would call this processToReuse. LGTM otherwise.

[youenn fablet]

Created attachment 324274 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 324274 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 324274 [details]:

http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[Chris Dumez]

Comment on attachment 324274 [details]
Patch

Clearing flags on attachment: 324274

Committed r223713: <https://trac.webkit.org/changeset/223713>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

Comment on attachment 324274 [details]
Patch

Is it possible to write a test for this change?

[Chris Dumez]

(In reply to Daniel Bates from comment #10)
> Comment on attachment 324274 [details]
> Patch
> 
> Is it possible to write a test for this change?

This is a crash fix which was split out of Bug 178475. When Bug 178475 lands, if API tests and layout tests do not crash, then this patch works as intended.

[Radar WebKit Bug Importer]

<rdar://problem/35568673>