Bug 178521 – Test262: RegExp/property-escapes/generated/Emoji_Component.js fails with current RegExp Unicode Properties implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

The test262 test JSTests/test262/test/built-ins/RegExp/property-escapes/generated/Emoji_Component.js fails with the current implementation of RegExp Unicode Properties.  The failure is:
Exception: Test262Error: `\P{Emoji_Component}` should match U+00200D (`‍`)

I had some discussion with Mathias Bynens, who wrote both the Unicode Properties spec change proposal and this test, about a week ago.  He stated that this area of the Unicode Properties spec is still being revised.

We should fix our implementation if needed when the spec and / or tests are finalized.

[Michael Saboff]

<rdar://problem/34864939>

[Michael Saboff]

The issue is that the test262 test is expecting results based on Emoji 5.0 and JSC is built with the Emoji 6.0 data file.

[Michael Saboff]

Created attachment 324301 [details]
Patch

[JF Bastien]

Comment on attachment 324301 [details]
Patch

I'm not sure I get this: deleting entries made more tests pass?  I assume you're right, so r=me.

[JF Bastien]

Oh actually, test262 is wrong: TC39 now floats the Unicode version to "the latest Unicode version", so we can be at 6.0 and we're correct. So this is a bad test.

[Michael Saboff]

(In reply to JF Bastien from comment #5)
> Oh actually, test262 is wrong: TC39 now floats the Unicode version to "the
> latest Unicode version", so we can be at 6.0 and we're correct. So this is a
> bad test.

The issue is that 6.0 is an unratified draft at this point.

[WebKit Commit Bot]

Comment on attachment 324301 [details]
Patch

Clearing flags on attachment: 324301

Committed r223724: <https://trac.webkit.org/changeset/223724>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.