Bug 178521 - Test262: RegExp/property-escapes/generated/Emoji_Component.js fails with current RegExp Unicode Properties implementation
Summary: Test262: RegExp/property-escapes/generated/Emoji_Component.js fails with curr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-19 10:23 PDT by Michael Saboff
Modified: 2017-10-19 16:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch (26.16 KB, patch)
2017-10-19 15:30 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2017-10-19 10:23:30 PDT
The test262 test JSTests/test262/test/built-ins/RegExp/property-escapes/generated/Emoji_Component.js fails with the current implementation of RegExp Unicode Properties.  The failure is:
Exception: Test262Error: `\P{Emoji_Component}` should match U+00200D (`‍`)

I had some discussion with Mathias Bynens, who wrote both the Unicode Properties spec change proposal and this test, about a week ago.  He stated that this area of the Unicode Properties spec is still being revised.

We should fix our implementation if needed when the spec and / or tests are finalized.
Comment 1 Michael Saboff 2017-10-19 10:24:20 PDT
<rdar://problem/34864939>
Comment 2 Michael Saboff 2017-10-19 14:25:53 PDT
The issue is that the test262 test is expecting results based on Emoji 5.0 and JSC is built with the Emoji 6.0 data file.
Comment 3 Michael Saboff 2017-10-19 15:30:15 PDT
Created attachment 324301 [details]
Patch
Comment 4 JF Bastien 2017-10-19 15:33:58 PDT
Comment on attachment 324301 [details]
Patch

I'm not sure I get this: deleting entries made more tests pass?  I assume you're right, so r=me.
Comment 5 JF Bastien 2017-10-19 15:34:52 PDT
Oh actually, test262 is wrong: TC39 now floats the Unicode version to "the latest Unicode version", so we can be at 6.0 and we're correct. So this is a bad test.
Comment 6 Michael Saboff 2017-10-19 15:39:34 PDT
(In reply to JF Bastien from comment #5)
> Oh actually, test262 is wrong: TC39 now floats the Unicode version to "the
> latest Unicode version", so we can be at 6.0 and we're correct. So this is a
> bad test.

The issue is that 6.0 is an unratified draft at this point.
Comment 7 WebKit Commit Bot 2017-10-19 16:26:10 PDT
Comment on attachment 324301 [details]
Patch

Clearing flags on attachment: 324301

Committed r223724: <https://trac.webkit.org/changeset/223724>
Comment 8 WebKit Commit Bot 2017-10-19 16:26:11 PDT
All reviewed patches have been landed.  Closing bug.