RESOLVED FIXED 178512
[Settings] Move global settings into their own file 
https://bugs.webkit.org/show_bug.cgi?id=178512
Summary [Settings] Move global settings into their own file
Sam Weinig
Reported 2017-10-19 06:08:25 PDT
[Settings] Move global settings into their own file
Attachments
Patch (142.06 KB, patch)
2017-10-19 06:24 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (142.06 KB, patch)
2017-10-19 06:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (142.66 KB, patch)
2017-10-19 07:47 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (143.69 KB, patch)
2017-10-19 07:51 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (143.91 KB, patch)
2017-10-19 10:10 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (145.02 KB, patch)
2017-10-19 10:19 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (145.09 KB, patch)
2017-10-19 12:44 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (146.77 KB, patch)
2017-10-19 14:26 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-10-19 06:24:50 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2017-10-19 06:38:55 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2017-10-19 07:47:38 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2017-10-19 07:51:19 PDT
Created attachment 324230 [details] Patch
Darin Adler
Comment 5 2017-10-19 09:20:34 PDT
Comment on attachment 324230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324230&action=review > Source/WebCore/ChangeLog:10 > + like to discourage, as WebCore can operate in a process with mulitple clients, each of typo: multiple > Source/WebCore/html/HTMLMediaElement.cpp:6822 > + return DeprecatedGlobalSettings::networkInterfaceName(); Looks like iOS build is failing because this file is missing an include of DeprecatedGlobalSettings.h. > Source/WebCore/page/DeprecatedGlobalSettings.h:33 > +class DeprecatedGlobalSettings { I think it would be good to delete the constructor.
Sam Weinig
Comment 6 2017-10-19 10:10:09 PDT
Created attachment 324244 [details] Patch
Sam Weinig
Comment 7 2017-10-19 10:19:30 PDT
Created attachment 324246 [details] Patch
Sam Weinig
Comment 8 2017-10-19 12:44:40 PDT
Created attachment 324264 [details] Patch
Sam Weinig
Comment 9 2017-10-19 14:26:36 PDT
Created attachment 324286 [details] Patch
WebKit Commit Bot
Comment 10 2017-10-19 16:03:01 PDT
Comment on attachment 324286 [details] Patch Clearing flags on attachment: 324286 Committed r223720: <https://trac.webkit.org/changeset/223720>
WebKit Commit Bot
Comment 11 2017-10-19 16:03:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-11-15 13:02:35 PST
<rdar://problem/35568669>
Note You need to log in before you can comment on or make changes to this bug.