Bug 178503 – [FrameView::layout cleanup] Replace m_nestedLayoutCount with isLayoutNested()

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

We don't really care how nested the layout is, all we need to know whether it is.

[Radar WebKit Bug Importer]

<rdar://problem/35066561>

[zalan]

Created attachment 324205 [details]
Patch

[zalan]

Created attachment 324206 [details]
Patch

[Antti Koivisto]

Comment on attachment 324206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324206&action=review

> Source/WebCore/page/FrameView.h:811
> +    enum class LayoutNestedState { Invalid, NotNested, Nested };
> +    LayoutNestedState m_layoutNestedState { LayoutNestedState::Invalid };

Maybe NotInLayout instead if Invalid?

Wonder if we could some some sort of LayoutContext struct that would contain stuff that only makes sense during layout.

[zalan]

Created attachment 324233 [details]
Patch

[zalan]

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 324206 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324206&action=review
> 
> > Source/WebCore/page/FrameView.h:811
> > +    enum class LayoutNestedState { Invalid, NotNested, Nested };
> > +    LayoutNestedState m_layoutNestedState { LayoutNestedState::Invalid };
> 
> Maybe NotInLayout instead if Invalid?
> 
> Wonder if we could some some sort of LayoutContext struct that would contain
> stuff that only makes sense during layout.
I was thinking about that too! Once I am done with this remove/rearrange/refactor frameview::layout, I'll take another look and see what type of context we could come up with.

[WebKit Commit Bot]

Comment on attachment 324233 [details]
Patch

Clearing flags on attachment: 324233

Committed r223689: <https://trac.webkit.org/changeset/223689>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.