Bug 178497 – Implement ServiceWorkerRegistration.scope / updateViaCache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Implement ServiceWorkerRegistration.scope / updateViaCache.

[Chris Dumez]

Created attachment 324194 [details]
Patch

[youenn fablet]

Comment on attachment 324194 [details]
Patch

LGTM once the bots are happy.

View in context: https://bugs.webkit.org/attachment.cgi?id=324194&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistration.h:66
>      virtual ScriptExecutionContext* scriptExecutionContext() const;

Can you mark these two as final as well?

> Source/WebCore/workers/service/ServiceWorkerRegistrationData.h:74
> +    decoder >> updateViaCache;

I wonder whether decoder >> key >> identifier >> scopeURL >> updateViaCache would be something we want.
That would match the encoder version nicely but we do not return as early and it is less debuggable.

> Source/WebCore/workers/service/ServiceWorkerRegistrationData.h:78
> +    return {{ WTFMove(*key), WTFMove(*identifier), WTFMove(*scopeURL), WTFMove(*updateViaCache) }};

Does style say to put a space between {{ or }}?

[Chris Dumez]

Created attachment 324196 [details]
Patch

[Chris Dumez]

Created attachment 324204 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 324204 [details]
Patch

Clearing flags on attachment: 324204

Committed r223652: <https://trac.webkit.org/changeset/223652>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35067071>

[Ben Kelly]

FYI, there is an open spec issue about updateViaCache:

https://github.com/w3c/ServiceWorker/issues/1189