Implement ServiceWorkerRegistration.scope / updateViaCache.
Created attachment 324194 [details] Patch
Comment on attachment 324194 [details] Patch LGTM once the bots are happy. View in context: https://bugs.webkit.org/attachment.cgi?id=324194&action=review > Source/WebCore/workers/service/ServiceWorkerRegistration.h:66 > virtual ScriptExecutionContext* scriptExecutionContext() const; Can you mark these two as final as well? > Source/WebCore/workers/service/ServiceWorkerRegistrationData.h:74 > + decoder >> updateViaCache; I wonder whether decoder >> key >> identifier >> scopeURL >> updateViaCache would be something we want. That would match the encoder version nicely but we do not return as early and it is less debuggable. > Source/WebCore/workers/service/ServiceWorkerRegistrationData.h:78 > + return {{ WTFMove(*key), WTFMove(*identifier), WTFMove(*scopeURL), WTFMove(*updateViaCache) }}; Does style say to put a space between {{ or }}?
Created attachment 324196 [details] Patch
Created attachment 324204 [details] Patch
Comment on attachment 324204 [details] Patch Clearing flags on attachment: 324204 Committed r223652: <https://trac.webkit.org/changeset/223652>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35067071>
FYI, there is an open spec issue about updateViaCache: https://github.com/w3c/ServiceWorker/issues/1189