Bug 178496 - [FrameView::layout cleanup] Group related pre-layout code to improve readability
Summary: [FrameView::layout cleanup] Group related pre-layout code to improve readability
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-18 18:25 PDT by zalan
Modified: 2017-10-18 19:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.36 KB, patch)
2017-10-18 18:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.72 KB, patch)
2017-10-18 18:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-18 18:25:14 PDT 
asserts
member variable resets
etc.
Comment 1 Radar WebKit Bug Importer 2017-10-18 18:25:58 PDT 
<rdar://problem/35065718>
Comment 2 zalan 2017-10-18 18:34:58 PDT 
Created attachment 324193 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-10-18 18:44:31 PDT 
Comment on attachment 324193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324193&action=review

> Source/WebCore/page/FrameView.cpp:1360
> +    // we shouldn't enter layout() while painting

Sentence case please.

> Source/WebCore/page/FrameView.cpp:1363
> +        LOG(Layout, "  in  is disallowed, bailing");

Please change the message to distinguish this from the case above. This should say "in painting is".
Comment 4 zalan 2017-10-18 18:55:44 PDT 
Created attachment 324195 [details]
Patch
Comment 5 WebKit Commit Bot 2017-10-18 19:22:48 PDT 
Comment on attachment 324195 [details]
Patch

Clearing flags on attachment: 324195

Committed r223649: <https://trac.webkit.org/changeset/223649>
Comment 6 WebKit Commit Bot 2017-10-18 19:22:50 PDT 
All reviewed patches have been landed.  Closing bug.